ViaEth / PayViaEth

Non-Custodial Woocommerce Ethereum Payment Plugin
3 stars 1 forks source link

Please use wp_enqueue commands #19

Open ViaEth opened 3 years ago

ViaEth commented 3 years ago

Your plugin is not correctly including JS and/or CSS. You should be using the built in functions for this:

https://developer.wordpress.org/reference/functions/wp_enqueue_script/ https://developer.wordpress.org/reference/functions/wp_enqueue_style/ And remember you can use this function to add inline javascript:

https://developer.wordpress.org/reference/functions/wp_add_inline_script/ As of WordPress 5.7, you can pass attributes like async, nonce, and type by using new functions and filters:

https://make.wordpress.org/core/2021/02/23/introducing-script-attributes-related-functions-in-wordpress-5-7/ If you're trying to enqueue on the admin pages you'll want to use the admin enqueues

https://developer.wordpress.org/reference/hooks/admin_enqueue_scripts/ https://developer.wordpress.org/reference/hooks/admin_print_scripts/ https://developer.wordpress.org/reference/hooks/admin_print_styles/ Example(s) from your plugin:

PayViaEth-master/ethereumpay/ethereumpay.tpl.php:16: PayViaEth-master/ethereumpay/ethereumpay.tpl.php:10:<script type="text/javascript" src=" PayViaEth-master/ethereumpay/ethereumpay.tpl.php:12:<script type="text/javascript" src="