search

ViaEth / PayViaEth

Non-Custodial Woocommerce Ethereum Payment Plugin
3 stars 1 forks source link

Included Unneeded Folders #22

Closed ViaEth closed 3 years ago

ViaEth commented 3 years ago

Your plugin includes folders and files that are not required for the running of your plugin. Some examples are:

vendor folders (bower, node, grunt, etc) documentation demos unit tests The entire library isn't going to be used by your users, and having all those files included is just extra weight to a plugin.

If you're trying to include the human-readable version of your own code (in order to comply with our guidelines) remember that we permit you to put links to them in your readme.

https://developer.wordpress.org/plugins/wordpress-org/detailed-plugin-guidelines/#4-code-must-be-mostly-human-readable

If you’ve made a Block plugin and used npm and webpack to compress and minify it, you can either include the source code within the published plugin or provide access to a public maintained source that can be reviewed, studied, and yes, forked.

But you can, and should, safely remove those other folders from your plugins.

Example(s) from your plugin:

PayViaEth-master/php-errors-log.php PayViaEth-master/tests

ViaEth commented 3 years ago

Removed file and folders that weren't needed.

Some of the folders were test related so I might need them again at some point in the future?

Tested that the plugin still works with the Koven test network.

Might still be extra files and folders and some folders are labeled "trash" but will need to take those on one at a time as i come across them.

Still need to remove and test index.php which has a file size of zero.

ViaEth commented 3 years ago

removed index.php and tested that the plugin still works. there still might be zero sized files somewhere in the code. I'll delete and test as I come across them.