search

ViaVersion / Mappings

Mapping generator and mapping files for the Via projects.
GNU General Public License v3.0
5 stars 9 forks source link

Change legacy_smiting #22

Closed Pantera07 closed 6 months ago

Pantera07 commented 6 months ago

https://github.com/ViaVersion/Mappings/blob/48f143edb068713237e2720ce35e4227c60722f9/mappings/diff/mapping-1.16to1.15.json#L5903 https://github.com/ViaVersion/Mappings/blob/48f143edb068713237e2720ce35e4227c60722f9/mappings/diff/mapping-1.19.4to1.20.json#L65

Before: old

After: new

FlorianMichael commented 6 months ago

What's the reason for this? Also, make sure there are no inventory desyncs when using the screen (afaik furnace was the only one which wasn't broken when I tested it).

Pantera07 commented 6 months ago

Oh I see.

FlorianMichael commented 6 months ago

I don't remember exactly, if the anvil works without any issues we could also use it, it's up to @kennytv .

kennytv commented 6 months ago

It should be fine for legacy smithing I think? We also already use that in 1.16->1.15, we might have just overlooked the anvil

FlorianMichael commented 6 months ago

We didn't overlooked the anvil, we had a discussion about that in staff-chat, I'll review this change later on and merge it if it works.

FlorianMichael commented 6 months ago

Testing this it seems to work, but I want to disable the input field (atleast cancel the packet updating it) so the output doesn't appear.