ViaVersion / ViaBackwards

Allows the connection of older clients to newer server versions for Minecraft servers.
https://hangar.papermc.io/ViaVersion/ViaBackwards
GNU General Public License v3.0
470 stars 89 forks source link

Block display entities are not visible on versions below 1.19.4 #537

Open GliczDev opened 1 year ago

GliczDev commented 1 year ago

'/viaversion dump' Output

https://dump.viaversion.com/1e457483840c3986a8461a04efc021f4ca4f80ad48cd2b8e87de7e4336856090

Console Error

No response

Bug Description

Block display entities are not visible on versions below 1.19.4 on 1.19.4 server

Steps to Reproduce

  1. Login into 1.19.4 server on e.g. 1.19.2
  2. Create a block display entity

Expected Behavior

Block display entities should be visible as invisible armorstands with block on their head

Additional Server Info

No response

Checklist

Barvalg commented 1 year ago

Platform: git--Paper--468%20%28MC%3A%201.19.4%29
ViaVersion (4.6.2): 1 commits behind master
ViaBackwards(4.6.2-SNAPSHOT): Even with master

Please try the latest build(s) from https://ci.viaversion.com/. In case the issue still persists send the new dump

GliczDev commented 1 year ago

https://github.com/ViaVersion/ViaBackwards/blob/dev/common/src/main/java/com/viaversion/viabackwards/protocol/protocol1_19_3to1_19_4/packets/EntityPackets1_19_4.java ^ doesn't have block display entity rewriter Also, I think it should change it to falling block, not armor stand (my friend knows how to create an resizable entity like block display entity, but he said, he won't tell me how can i do this :/ sorry)

I'd create a PR to fix it, but i don't know how can i get meta index of e.g. block of this display entity

edit: i found block meta index on wiki.vg, I'll try to fix it and create a PR