ViaVersion / ViaBackwards

Allows the connection of older clients to newer server versions for Minecraft servers.
https://hangar.papermc.io/ViaVersion/ViaBackwards
GNU General Public License v3.0
459 stars 87 forks source link

[1.20.5->1.20.3] show_item tag is not handled #771

Closed Pantera07 closed 1 month ago

Pantera07 commented 4 months ago

'/viaversion dump' Output

https://dump.viaversion.com/a1201c889f00d83362dc8894a03f5b943a8be2d8b1e84fa5982254fa9983fc29

Console Error

none

Bug Description

show_item tag is not handled

Steps to Reproduce

/tellraw @p {"hoverEvent":{"action":"show_item","contents":{"components":{"minecraft:container":[{"item":{"components":{"minecraft:fireworks":{"explosions":[],"flight_duration":2}},"count":1,"id":"minecraft:firework_rocket"},"slot":0},{"item":{"components":{"minecraft:fireworks":{"explosions":[],"flight_duration":3}},"count":1,"id":"minecraft:firework_rocket"},"slot":26}]},"count":1,"id":"minecraft:shulker_box"}},"text":"Test"}
/tellraw @p {"hoverEvent":{"action":"show_item","contents":{"components":{"minecraft:fireworks":{"explosions":[],"flight_duration":2}},"count":1,"id":"minecraft:firework_rocket"}},"text":"Test"}

Expected Behavior

show_item tag should not disappear.

Additional Server Info

No response

Checklist

Barvalg commented 4 months ago

Platform: 1.20.6--130--5d8e53d%20%28MC%3A%201.20.6%29
ViaVersion (5.0.0-SNAPSHOT): Even with dev
ViaBackwards(5.0.0-SNAPSHOT): Even with dev

FlorianMichael commented 4 months ago

Already known, I still didn't came arround to write the needed conversions, but it's on my TODO

kennytv commented 1 month ago

Tracking this here instead https://github.com/ViaVersion/ViaBackwards/issues/788