ViaVersion / ViaBackwards

Allows the connection of older clients to newer server versions for Minecraft servers.
https://hangar.papermc.io/ViaVersion/ViaBackwards
GNU General Public License v3.0
442 stars 85 forks source link

Buying trial chamber map on 1.20.5/6 server permanently kicks player #789

Closed Kichura closed 1 month ago

Kichura commented 1 month ago

'/viaversion dump' Output

https://dump.viaversion.com/46cad9c45030b019313f831fa6ccb946c9349eeac0efc2b4809202c48a088f74

Console Error

Only player disconnected is seen in console but 1.20.4 client shows this.

Bug Description

When buying a trial chamber map from a cartography villager and placing it into inventory, the player is permanently kicked until their inventory data is cleared or they switch to same version as server.

Steps to Reproduce

  1. Create a 1.20.5/6 server with viaversion and viabackwards on it,
  2. Create a vanilla 1.20.4 client instance,
  3. Join the server then summon a villager,
  4. Mark the villager as a cartography-based one,
  5. Keep buying from villager until trial chamber map is unlocked,
  6. Buy the map and place it into inventory.

Expected Behavior

The player is not kicked for having the broken map.

Additional Server Info

  1. This test server did not use any proxies,
  2. Paper 1.20.6, (Commit build: fe7043e)
  3. ViaVersion 5.0.1-SNAPSHOT with ViaBackwards 5.0.0.

Checklist

Barvalg commented 1 month ago

Platform: 1.20.6--145--fe7043e%20%28MC%3A%201.20.6%29
ViaVersion (5.0.1-SNAPSHOT): Even with master
ViaBackwards(5.0.0): Even with master