ViaVersion / ViaBackwards

Allows the connection of older clients to newer server versions for Minecraft servers.
https://hangar.papermc.io/ViaVersion/ViaBackwards
GNU General Public License v3.0
442 stars 85 forks source link

Enchants are incorrectly remapped when connecting with a pre-1.21 client on a 1.21 server #795

Closed MrPowerGamerBR closed 1 month ago

MrPowerGamerBR commented 1 month ago

'/viaversion dump' Output

https://dump.viaversion.com/24f698e31c09a6b1acb4bef851bab32c9d128accf0d9ae4f02ad601968fd6bab

Console Error

no errors

Bug Description

It seems that ViaBackwards is not remapping enchantments correctly (Unbreakable is missing) and some enchantments are incorrectly remapped (Mending... 3?)

1.21:

javaw_cmwGoI6RM8

1.20.6:

javaw_nx5bm9wcF2

Steps to Reproduce

Just enchant an item with enchantments

Expected Behavior

The enchants are correctly remapped on pre-1.21 versions

Additional Server Info

No response

Checklist

Barvalg commented 1 month ago

Platform: 1.21--DEV--e1c5e17%20%28MC%3A%201.21%29
ViaVersion (5.0.1-SNAPSHOT): Even with master
ViaBackwards(5.0.1-SNAPSHOT): 1 commits behind master

Please update all Via* plugins from https://ci.viaversion.com/.In case the issue still persists send the new dump and the issue will be reopened

Billybobertjoe commented 5 days ago

still incorrectly remapped in enchantment tables 1.20.6 image image image

1.21 image image image

Dump: https://dump.viaversion.com/f985e78f9e7b056f8a2ee9e536f357697b8e176a108b2e48b3c8341975407131