ViaVersion / ViaBackwards

Allows the connection of older clients to newer server versions for Minecraft servers.
https://hangar.papermc.io/ViaVersion/ViaBackwards
GNU General Public License v3.0
442 stars 85 forks source link

infinite potion effect for 1.19.3- give flash #796

Closed emanondev closed 1 month ago

emanondev commented 1 month ago

'/viaversion dump' Output

https://dump.viaversion.com/e84df5f8e04afc6ad87e81774282378fa44ae58020c18004a1fe7046450179ab

Console Error

No response

Bug Description

Giving infinite potion effect (duration as -1 for 1.19.4+) is displayed as 0:00 on older clients, while this isn't a big issue for most of effects, night vision give bothering flashing color transitions for background and would be much better if displayed as a very long duration instead of 0:00 duration

https://i.imgur.com/VJ9Asqj.mp4

An user (server owner) reported this issue to me, thinking my plugin was doing the error, after a fast test from the user it was clear the issue was client version related, so forgive me if i hadn't test if with build from https://ci.viaversion.com/ the issue still persists

Steps to Reproduce

start a server on 1.20.4 connect with a 1.18 client obtain infinite effect of night vision with minecraft command or with any other plugin

Expected Behavior

No flashing screen

Additional Server Info

No response

Checklist

Barvalg commented 1 month ago

Platform: git--Pufferfish--51%20%28MC%3A%201.20.4%29
ViaVersion (5.0.0): 10 commits behind master
ViaBackwards(5.0.0): 10 commits behind master

Please update all Via* plugins from https://ci.viaversion.com/.In case the issue still persists send the new dump and the issue will be reopened