Sound pitch is not translated between versions

Pablete1234 commented 3 weeks ago

`/viaversion dump` Output

https://dump.viaversion.com/cf4487d47d27d9e029cb71ee8daa2431315a2fce876ea3ad855cda7a26f8f251

Console Error

No response

Bug Description

It appears that viaversion does not bother mapping the pitch of sounds, which leads to some things sounding very off.

The one thing that stands out is pressure plates, this is the serverside behavior across versions: in 1.21, sends a "block.wooden_pressure_plate.click_on" with pitch 1.0F in 1.18.2, sends a "block.wooden_pressure_plate.click_on" with pitch 0.8F (different for on/off and stone/wood) in 1.8.8, sends a "random.click" with pitch 0.6F (diff for turning on/off)

However, viaversion will just translate the keys and call it a day, and when a 1.18.2 client hears the sound with a pitch of 1, it sounds way higher pitch than normal (0.8).

I am assuming that the sound in the vanilla pack itself has changed over time, so before the pitch was changed via the packet, while in the newest versions the sound file itself is already pitched to sound ok with a pitch of 1.0. Pressure plates are the one we noticed, but this seems likely to have happened to more sounds.

Steps to Reproduce

Setup a server running in 1.20.6/1.21 paper

Log in with a 1.20.6/1.21 client Step on a wooden and/or stone pressure plate The sound is normal, it sounds correct

Log in with a 1.18.2 client Step on a wooden and/or stone pressure plate The sound is the correct one ("pressure plate clicks", as shown if accessibility->show subtitles is enabled) but the pitch is not the right one

Log in with a 1.8 client Step on a wooden and/or stone pressure plate, the sound is very off, sounds like a dispenser not a pressureplate

Expected Behavior

The not just the key but the pitch should also be mapped across versions

Additional Server Info

No response

Checklist

[X] Via plugins are only running on EITHER the backend servers (e.g. Paper) OR the proxy (e.g. Velocity), not on both.
[X] I have included a ViaVersion dump.
[X] If applicable, I have included a paste (not a screenshot) of the error.
[X] I have tried the latest build(s) from https://ci.viaversion.com/ and the issue still persists.
[X] I have looked at https://www.spigotmc.org/resources/viarewind-legacy-support.52924/ and it does not offer a fix for my problem