ViaVersion / ViaBackwards

Allows the connection of older clients to newer server versions for Minecraft servers.
https://hangar.papermc.io/ViaVersion/ViaBackwards
GNU General Public License v3.0
459 stars 87 forks source link

Incorrect Armor Trims Displayed #847

Closed Coswics closed 2 months ago

Coswics commented 2 months ago

'/viaversion dump' Output

https://dump.viaversion.com/8afa7132720d84a7d9afaf1cfad7cd890c7454ef46df0da092cb28e603127eb3

Console Error

No Console Error.

Bug Description

Custom Armor Trims (provided by a datapack & resourcepack) Don't Display Correctly, if at all on lower client versions. image 2024-07-31_23 37 16

Steps to Reproduce

  1. Create New Server (Paper was tested, in this instance)
  2. Install a Data Pack that provides custom armor trim textures/models, such as Laser's Armor Trims Plus; modified to have the new trim materials substituted for older items
  3. Login to the server with one player on a version between 1.20.5 and 1.21, and the other on any version on between 1.19.4 and 1.20.4
  4. Give yourself one of the custom trims via a command or via the smithing table
  5. Wear or display the armor on an armor stand
  6. Observe

Expected Behavior

Armor Trim Displays Properly, as the custom trim material and pattern; regardless of version (due to both the datapack and texture pack formatting not really changing, tested on 1.20.4 and both 1.21 the packs work by themselves and function as intended) could be an issue with trim formatting possibly? Additionally; for servers on newer versions; the armor trim materials arent translated to older equivalents; this error is gotten when a player tries to join a 1.21 server on 1.20.4 or below client 2024-08-01_00 00 35

Additional Server Info

Nothing but viaversion, viabackwards, and the datapack are installed

Checklist

Barvalg commented 2 months ago

Platform: 1.21--123--0a1be9a%20%28MC%3A%201.21%29
ViaVersion (5.0.2): Even with master
ViaBackwards(5.0.2): 4 commits behind master

Please update all Via* plugins from https://ci.viaversion.com/.In case the issue still persists send the new dump and the issue will be reopened

Coswics commented 2 months ago

https://dump.viaversion.com/adb53a4e000980f36588537389e72eed28f4801cd86e2c5f6b084973f1a75af2

Barvalg commented 2 months ago

Platform: 1.21--123--0a1be9a%20%28MC%3A%201.21%29
ViaVersion (5.0.2): Even with master
ViaBackwards(5.0.3-SNAPSHOT): Even with master

Coswics commented 2 months ago

Additionally, here's the exact dp we used and the resource pack 2024-08-01_14 30 11 2024-08-01_14 30 25 Lasers Pack (Modified).zip New Trim DP3.zip