ViaVersion / ViaBackwards

Allows the connection of older clients to newer server versions for Minecraft servers.
https://hangar.papermc.io/ViaVersion/ViaBackwards
GNU General Public License v3.0
464 stars 88 forks source link

Shulker box tooltip mod empty spaces are skipped #888

Open Kyuunex opened 2 months ago

Kyuunex commented 2 months ago

/viaversion dump Output

https://dump.viaversion.com/5b6cf01a99802a876de702cfc7f08064697a032417b212476b6f3963438e5aab

Console Error

No response

Bug Description

Server is 1.19.4 I recently upgraded my instance from 1.20.4 to 1.20.6 and noticed the empty spots in my shulker tooltips were skipped. I made sure this is a Via issue and not the Shulker Box Tooltip mod issue.

1.20.4 client: 1.20.4

1.20.6 and 1.21 clients: 1.20.6

This may not seem like a huge issue but it gets annoying on anarchy servers when you are trying to make a kit and need to get it right.

Steps to Reproduce

  1. Install: 1.20.6 or 1.21 client. Mods: ViaFabric, Shulker Box Tooltip and Mod Menu
  2. Launch
  3. In the Mod menu, locate Shulker Box Tooltip and in it's settings toggle on "Swap Modes" and "Always On".
  4. Connect to 1.19.4 server
  5. Hover over a shulker box that has empty slots in between items
  6. Notice the empty slots are skipped

Expected Behavior

Empty slots in the shulker box should exist.

Additional Server Info

No response

Checklist

Kichura commented 2 months ago

Does this continue when using real 1.19.4 client on same server?

Kyuunex commented 2 months ago

This issue does not exist when using a real 1.19.4 client on this 1.19.4 server. (not having Via installed)

Kichura commented 2 months ago

will be investigated then.

Kichura commented 2 months ago

Couldn't seem to reproduce this issue, Can you try this with a clean world save?

This is a 1.20.4 client on fabric 1.19.4 client during my test run: a

Kyuunex commented 2 months ago

perhaps there is some miscommunication This is what the shulker box in question actually looks like when being opened normally

2024-08-12T14:55:41+00:00

and these empty slots get lost when hovering over with the mod

Kichura commented 2 months ago

perhaps there is some miscommunication This is what the shulker box in question actually looks like when being opened normally

and these empty slots get lost when hovering over with the mod

Tried to copy what your shulker box contains one-by-one and this is what i got: b From what i understand about this mod, It sorts the items that have less than 64 to the last slots and the rest seem to be sorted with another mechanism that get sorted otherwise no matter how scrambled it is. (Slime and Iron were in very last two slots)

Kyuunex commented 2 months ago

here's a simpler repro and world save

client is 1.20.6, world save is 1.19.4 for the server 2024-08-12T16:11:15+00:00 Archive.zip

Kichura commented 2 months ago

here's a simpler repro and world save

client is 1.20.6, world save is 1.19.4 for the server

Still seems to be properly sorted, Is your config the default btw? c

Kyuunex commented 2 months ago

this is taken on a native 1.19.4 client on the same server 2024-08-12T16:16:30+00:00

regarding the config: In the Mod menu, locate Shulker Box Tooltip and in it's settings toggle on "Swap Modes" and "Always On".

Kyuunex commented 2 months ago

shulkerboxtooltip.json this is my config file, rename to shulkerboxtooltip.json5 and put it in the config folder

Kichura commented 2 months ago

Now i can reproduce, except i now managed to find the issue itself which tells me that this is not a viafabric-specific issue to some extent. Except if the mod was present on 1.19.4 server then it's busted on 1.20.5+ clients cuz of the custom payload packets being too large.

Kyuunex commented 2 months ago

This is a non-issue when I play on a 1.20.6 server with a 1.20.6 client (with the same exact Shulker mod). Which is why I figured it may be a Via translation issue.

Kichura commented 2 months ago

Going to try this with 1.20.5/6 to see if i can get anything else to change with this as the mod states it also accepts server-side.

Kichura commented 2 months ago

Ok it's not busted on 1.20.5+ servers anymore and it properly renders the contents in same slots as it's in actual view, meaning 1.20.4 and older are broken it seems.