ViaVersion / ViaFabric

Client-side and server-side ViaVersion implementation for Fabric
https://viaversion.com/fabric
GNU General Public License v3.0
324 stars 38 forks source link

Unable to join 1.20.2 server on 1.20.1 client #275

Closed Libreh closed 10 months ago

Libreh commented 1 year ago

/viaversion dump Output

https://dump.viaversion.com/e97266abb81866ad38830e9119bf77829566f77852a01d4bf3ae3a85771900b5

Console Error

https://paste.gg/p/anonymous/00e93cd78dac4bffb6b75a578103429b

Bug Description

Unable to join 1.20.2 server on 1.20.1 client

Steps to Reproduce

  1. Join 1.20.2 server using 1.20.1 client
  2. Not connect because of error

Expected Behavior

The client should be able to successfully connect to the server

Additional Server Info

I'm not using a proxy error

Checklist

luavixen commented 1 year ago

Had this same issue with a large server, had to downgrade to 1.20.1. Can reproduce.

Kichura commented 1 year ago

Confirmed bug.

FlorianMichael commented 1 year ago

Can you try the version on the dev branch?

Kichura commented 1 year ago

I have tested the dev branch and it manages to persist here.

uricot commented 12 months ago

Same issue here

Kichura commented 11 months ago

Update: This has turned out to be a fabric API problem, although i'm unsure when this will be resolved at all; 1.19.4 servers and older however aren't affected.

GrueFinder commented 11 months ago

Update: This has turned out to be a fabric API problem, although i'm unsure when this will be resolved at all; 1.19.4 servers and older however aren't affected.

Are there any more updates on this? You're saying it's a Fabric API problem, but the Fabric API team is saying it's an (unreported) ViaBackwards problem, and at the moment it doesn't seem like anyone is taking ownership of it.

Kichura commented 11 months ago

Update: This has turned out to be a fabric API problem, although i'm unsure when this will be resolved at all; 1.19.4 servers and older however aren't affected.

Are there any more updates on this? You're saying it's a Fabric API problem, but the Fabric API team is saying it's an (unreported) ViaBackwards problem, and at the moment it doesn't seem like anyone is taking ownership of it.

One of the methods we have thought of is attempting to inject into Fabric's API or/and block fabric's payloads in viaversion but this is ultimately the worst solution out of anything else, but we are open to ideas to how to resolve this for both sides.

SyedOmarNoor commented 11 months ago

I was thinking of trying to replace the networking jar in fabric api with a pre-3324 one and seeing if that works, might try later (iirc the api is referenced by the mods so changing it at the api file should affect the mods as well)

SyedOmarNoor commented 11 months ago

so i tried just doing that and it doesnt seem to help? i put the 88.5 networking into 90.7

RealKomander commented 10 months ago

Looks like I have the same issue, have you contacted fabricAPI team? Have they done anything about it?

Kichura commented 10 months ago

Fixed in d30766a.