1.16.5 server, 1.20.2 client: ERROR IN Protocol1_17To1_16_4 IN REMAP OF ENTITY_METADATA

FrostBird347 commented 10 months ago

`/viaversion dump` Output

https://dump.viaversion.com/896385be5db801b8f5fc69b26dabc53c9a17f7eb2229ccbb563707711b4da9fe

Console Error

Bug Description

When a 1.20.2 client joins a 1.16.5 server, the error message ERROR IN Protocol1_17To1_16_4 IN REMAP OF ENTITY_METADATA is spammed in the logs and sometimes the player's connection times out while joining.

Steps to Reproduce

Host a 1.16.5 fabric server with viafabric
Connect to the server with a 1.20.2 client
Observe the error in the server log

Expected Behavior

This error should not occur while the player is joining.

Additional Server Info

Map used

Checklist

[ ] I have checked if this is specific to ViaFabric platform, and doesn't happen when running it on other platforms (Paper/Sponge/Velocity/Waterfall).
[X] I have included a ViaVersion dump.
[X] If applicable, I have included a paste (not a screenshot) of the error.
[ ] I have tried the latest build(s) from https://ci.viaversion.com/ and the issue still persists.

Kichura commented 10 months ago

This is likely caused by a bad third-party mod, Please perform a binary search to see what causes viafabric to complain about bad entity metadata packets being sent to server.

FrostBird347 commented 10 months ago

I still experience this issue after removing all mods except for viafabric and fabric api.

I have also updated the initial message to include the full log, without only these two mods installed.

Kichura commented 10 months ago

Can you test this on a clean world that has no data on it? if it still happens from there, you might have to update viafabric + viaversion jars to latest CI builds.

FrostBird347 commented 10 months ago

It does not occur on a clean world

Kichura commented 10 months ago

Then something bad has been stored in the world save. (possibly corrupt data or bad NBT items/blocks/etc is hidden somewhere)

Kichura commented 8 months ago

Closing this since this issue has turned out to be caused by bad world save after all, can be noticed by checking the bad achievements at beginning.

ViaVersion / ViaFabric