search

ViaVersion / ViaFabric

Client-side and server-side ViaVersion implementation for Fabric
https://viaversion.com/fabric
GNU General Public License v3.0
320 stars 36 forks source link

Ensure ViaManager is destroyed on the server on graceful shutdown #328

Closed pompompopi closed 2 months ago

pompompopi commented 2 months ago

In my testing with 1.20.6 and the latest snapshots versions of ViaVersion/ViaBackwards/ViaRewind (as detailed in the original issue) available on Hangar, this should fix #327.

A similar fix may be required for legacy client versions, but on the 1.20.6 client with the snapshot versions of ViaVersion/ViaBackwards/ViaRewind this issue doesn't seem to occur.

Kichura commented 2 months ago

compatibilityLevel is LGTM although the "Saving chunks" part is still horribly slow, might have to retest with 1.20.4 next.

turns out it's not viafabric's fault therefore false alarm but giving approval now.