ViaVersion / ViaFabric

Client-side and server-side ViaVersion implementation for Fabric
https://viaversion.com/fabric
GNU General Public License v3.0
326 stars 39 forks source link

AddressParser-related changes and fixes #371

Open Ampflower opened 3 months ago

Ampflower commented 3 months ago

Prefix Parsing

viafabric.v1.8;localhost is now valid. Additional meta, such as versions, can be separated by +, like for example, viafabric.v1.18+v-2;localhost.

Note, to minimise rewriting more than is necessary, any additional versions specified after the first will be ignored, conforming to the original parser's behavior for both the new and old syntax.

Ampflower commented 3 months ago

Changes to the address parser/format should be explained in the README.md file as well (to make sure users know about it).

I'll write the prefix format down tomorrow, since I'm rather tired. I'm not going to write in the ability to pile up additional options tho, since that was more so mimicking the quirk of the original parser to make sure any existing invalid input in the wild would still work as expected. That can be changed easily tho if that isn't desired; i.e. just don't loop and instead bail after first iteration.

Kichura commented 2 months ago

Decided to test the suffix and it seems to work fine on my end as far as i'm aware.

Kichura commented 3 weeks ago

This PR has conflicts present, Please attempt to resolve them if you wish to.