ViaVersion / ViaFabricPlus

Fabric mod to connect to EVERY Minecraft server version (Release, Beta, Alpha, Classic, Snapshots, Bedrock) with QoL fixes to the gameplay
GNU General Public License v3.0
381 stars 37 forks source link

Fog (MC >= 1.15.2) #344

Open 1zun4 opened 5 months ago

1zun4 commented 5 months ago

General Information

https://dump.viaversion.com/40898af1b6c6161527b7f8d3f9339f9e41ffe17e890ef5e284037260e7f7d4aa

Bug Description

On 1.15.2 and below, in some cases, fog will appear and remain until your player dies (respawning will fix this). This is also present in 1.13 and, if my testing is correct, 1.16+ does not seem to have this issue.

image image

Steps to Reproduce

  1. Select protocol version 1.15.2
  2. Join pika-network and go to BW or SW (join a game!)
  3. Now you are surrounded by fog.

https://github.com/ViaVersion/ViaFabricPlus/assets/12410754/09ac0a8b-25e9-4271-b8be-68cb73a22ab8

Expected Behavior

No fog. :)

FlorianMichael commented 4 months ago

This seems to be down to how ViaVersion handles registry changes in those versions (by basically not handling them at all).

lowercasebtw commented 1 month ago

is that a freaking cheat client?

anyways in 1.17+, fog is no longer plane/camera-z based. In version 1.16 and below, the fog used to be on camera-z/plane based where it would move with the camera, but in 1.17+ the fog is cylinder and follows player position instead.

I wish to see a option to get the old fog back, as I liked it more.