ViaVersion / ViaFabricPlus

Fabric mod to connect to EVERY Minecraft server version (Release, Beta, Alpha, Classic, Snapshots, Bedrock) with QoL fixes to the gameplay
GNU General Public License v3.0
415 stars 44 forks source link

[Request] 1.7 animations #376

Open 7n7e7o7 opened 8 months ago

7n7e7o7 commented 8 months ago

Problem Description

1.7 player animations and item animations to 1.20 (or whenever they changed).

Solution Description

animations can be found in the labymod 4.0 client for example. So please add 1.7 player animations: -Head Rotation -Backwards -Sneaking -Blockbuild -Heart -Damage -Hitbox

Alternatives

No response

Additional Info

No response

FlorianMichael commented 7 months ago

Sneaking is already implemented (there are multiple sneaking settings you should check out in Debug settings), I don't know about most animations you are mentioning here, it would be good if you could provide examples in form of short videos so we understand what you mean by e.g. "Backwards"?

7n7e7o7 commented 7 months ago

can I contact you somewhere else? discord for example

FlorianMichael commented 7 months ago

Yes, florianmichael

lowercasebtw commented 6 months ago

17w13a - The player's body now entirely faces to the front, when moving backwards. Prior to this snapshot, moving backwards would cause the player model to rotate one side, making it look like the player was strafing backwards somewhat.

1.12 Snapshot ^

Prior to 1.12, the player walking backwards would be tilted sideways a bit

FlorianMichael commented 6 months ago

Thanks for looking up the exact version, I'll see what I can do.

FlorianMichael commented 6 months ago

https://github.com/ViaVersion/ViaFabricPlus/commit/77c3a004b4c8d30bc1de8bbceb17c040bfe22bb8 - backwards animation is now implemented/fixed

lowercasebtw commented 6 months ago

Isn't sneaking already in par with 1.7?

Afaik, 1.8-1.12.2 broke the sneak animation

Then 1.13 fixed the smooth sneak animation which should be same as 1.7's

Then 1.14 just changed sneak height but the code is still the same, and viafab afaik alr changes the sneak height to be what it was 1.13 and below

So in turn, it should be identical to 1.7

Although, maybe its a speed difference, idk. It did feel off when playing vanilla 1.6.4 vs viafab 1.6.4 on 1.20

lowercasebtw commented 6 months ago

I do know in 1.7, there was a tilt to all items ingame, but idk how that would affect 1.20 stuff or packs

FlorianMichael commented 5 months ago

@lowercasebtw I would recommend opening multiple issues for the things you mentioned with a more detailed description of the problem (appending screenshots or a video would be helpful). If you manage to fix things up yourself, you can open pull requests.

NoboKik commented 5 months ago

Eating and clicking animations would be nice. Pretty sure in 1.7 if you are eating something and then holding left click and looking on the ground, it would swing the same way as if you were blocking the sword.

lowercasebtw commented 2 months ago

Implemented some of this stuff for 1.7 so far