search

ViaVersion / ViaFabricPlus

Fabric mod to connect to EVERY Minecraft server version (Release, Beta, Alpha, Classic, Snapshots, Bedrock) with QoL fixes to the gameplay
GNU General Public License v3.0
404 stars 42 forks source link

Cannot connect to servers with SRV record #380

Closed road2react closed 6 months ago

road2react commented 6 months ago

General Information

ViaFabricPlus-v3.1.0

Bug Description

Add na.scrims.network to server list.

image

MOTD shows, but the error "Velocity 1.7.2-1.20.1" shows up (should not show up), and joining server results in "Disconnected" screen

Resolving the SRV record becomes 172.65.204.32:45653, and adding that as a server connects successfully

Steps to Reproduce

Add na.scrims.network to server list.

Expected Behavior

Should be able to connect

FlorianMichael commented 6 months ago

Hi, thanks for your bug report. Which version did you select in VFP?

road2react commented 6 months ago

1.8.x

FlorianMichael commented 6 months ago

Can not reproduce your issue using latest ViaFabricPlus, maybe one of your installed mods is breaking something?

road2react commented 6 months ago

Issue found; another mod was connecting through an intermediate server (similar to a proxy) for multiplayer.

ViaFabricPlus modified the code in ServerAddress: https://github.com/ViaVersion/ViaFabricPlus/blob/8b6715e3a3f9d78704b46a1ce7a5b6e7d00ef92e/src/main/java/de/florianmichael/viafabricplus/injection/mixin/fixes/minecraft/MixinServerAddress.java#L43

and due to the way the Minecraft code worked, it added a trailing . to resolved domain names, which messed up some other networking code.

FlorianMichael commented 6 months ago

Thanks for the research, which mod is it?