search

ViaVersion / ViaFabricPlus

Fabric mod to connect to EVERY Minecraft server version (Release, Beta, Alpha, Classic, Snapshots, Bedrock) with QoL fixes to the gameplay
GNU General Public License v3.0
401 stars 43 forks source link

Remove Hit Delay in < 1.8 version #403

Closed d0j1a1701 closed 4 months ago

d0j1a1701 commented 4 months ago

Problem Description

Just like you read on https://ghast.io/hitdelayfixmod, Minecraft 1.8+ introduced "hit delay" and severely affected PvP players.

Solution Description

Disable hit delay in versions <= 1.7.10 and add an optional switch to do the same in <1.9. This change is extremely simple and is detailed in the article mentioned above.

Alternatives

No response

Additional Info

No response

christopherplaysminecraft commented 4 months ago

add an optional switch to do the same in <1.9

Correct me if I'm wrong, but aren't those "1.7 NoHitDelay" mods banned on 1.8.x servers, including Hypixel, because they allow you to hit a little bit faster. If that's the case I don't think there should be a toggle for it.

EDIT: Meant "banned on 1.8.x servers" and changed it to say that

FlorianMichael commented 4 months ago

Even if they are allowed on servers (which I think is the case) I'm not sure if this is out of goal for ViaFabricPlus as VFP's job is to take care between version differences and not to backport pvp mods in newer versions

FlorianMichael commented 4 months ago

Thanks for your suggestion. After speaking with a few people, I've concluded that some server owners view this as cheating. Given this, along with the out-of-goal question previously mentioned, I'll close this issue for now.

christopherplaysminecraft commented 4 months ago

Isn't this issue also about removing the hit delay in 1.7.10 in general (and lower versions if applicable; I don't know a lot about versions <1.8) Or is this already implemented?

(AFAIK there is a difference between 1.8 and <=1.7)

If I'm saying bs right now I'll blame it on my lack of sleep

d0j1a1701 commented 4 months ago

I did not see any modifications about clickMouse() in the code, and this is the source of the difference in attack delay between 1.7 and higher versions. If the higher version no longer uses this function, please remind me.

FlorianMichael commented 4 months ago

If that's an actual version change between 1.8 and 1.7, I'll implement it. Not sure when I get the time to proper investigate this but I will come back to it at some point. Thank you!