ViaVersion / ViaFabricPlus

Fabric mod to connect to EVERY Minecraft server version (Release, Beta, Alpha, Classic, Snapshots, Bedrock) with QoL fixes to the gameplay
GNU General Public License v3.0
403 stars 42 forks source link

Can't Join Server with Simple Voice Chat #532

Closed DreiPixel closed 1 month ago

DreiPixel commented 1 month ago

General Information

ViaVersion dump: https://dump.viaversion.com/4f41380712cb9074ac5e9e86bc8277822b96bbf7431fafb366c1d545e64bd341

Bug Description

Joining a Server with SimpleVoiceChat (having it both on Client and Server) Results in a Decoder Exception. Client is 1.21 and Server is 1.20.4 disconnect-2024-08-19_00.57.34-client.txt

Steps to Reproduce

  1. Have ViaFabricPlus and Simple Voice Chat installed (Client and Server)
  2. Try to Join Server
  3. Error

Expected Behavior

Not having that error and join the server WITH Simple Voice Chat.

FlorianMichael commented 1 month ago

Joining modded servers accross different versions is generally not supported; The issue is most likely SimpleVoiceChat having a different network protocol in 1.20.4 then in 1.21 which ViaFabricPlus doesn't support/rewrite.

Gaming32 commented 1 month ago

Simple Voice Chat is supposed to have a proper in the case of mismatched SVC versions. I can connect to a 1.20.1 server from 1.21 fine, if the version matches, and the error works correctly if the version does not match.

FlorianMichael commented 1 month ago

@DreiPixel If you can't reproduce this issue without Simple Voice Chat installed, I would recommend you to ask the SVC support for further help.

DreiPixel commented 1 month ago

SVC fixed support for ViaFabric on his side but the error is still happening. I dont know if there is anything that can be done on your side :/

Gaming32 commented 1 month ago

It works for me on a Fabric 1.20.1 server. I'm guessing there might be some issue with Velocity.

DreiPixel commented 1 month ago

It works for me on a Fabric 1.20.1 server. I'm guessing there might be some issue with Velocity.

mh that might be the issue but i doubt that Velocity will fix anything on their side.

FlorianMichael commented 1 month ago

You should try if it happens without Velocity in your setup and if so, report it to the Velocity developers. Since there is no evidence of this being an actual ViaFabricPlus issue, I am going to close it for now. Feel free to share any further information you get in this issue anyway.