ViaVersion / ViaFabricPlus

Fabric mod to connect to EVERY Minecraft server version (Release, Beta, Alpha, Classic, Snapshots, Bedrock) with QoL fixes to the gameplay
GNU General Public License v3.0
419 stars 44 forks source link

Incompatibility with Lithium when joining a multi-version server on 1.21.1 #619

Closed cursefroge closed 32 minutes ago

cursefroge commented 1 hour ago

General Information

ViaVersion Dump URL: https://dump.viaversion.com/27d3cd0de985155bb701e06def41ec18b6bb818f202a97426d8fd05f01a80afd latest.log: https://mclo.gs/OqpVzSf

Bug Description

On the latest commit of ViaFabricPlus, joining a server that allows multiple versions with VFP set to 1.21.1 while Lithium is installed causes the game to crash.

Steps to Reproduce

  1. Ensure VFP latest commit and Lithium 0.14.1-snapshot are installed
  2. Attempt to join hypixel.net using VFP set to 1.21.1

Expected Behavior

the game shouldn't crash when i join Hypixel on 1.21.1

FlorianMichael commented 1 hour ago

Did you tried only with lithium?

cursefroge commented 1 hour ago

yes, couldn't reproduce. also couldn't reproduce on any other version

FlorianMichael commented 40 minutes ago

Looking at the error this is most likely a duplicate of https://github.com/ViaVersion/ViaFabricPlus/issues/543 and lithium is just part of the error because they replace parts of the chunk code.

Kichura commented 36 minutes ago

If possible, can you check which mixin in lithium is causing this crash to occur?

FlorianMichael commented 36 minutes ago

As I said this is not related to lithium at all, no need for checking

cursefroge commented 32 minutes ago

yep. i'll close in favor of that issue