search

ViaVersion / ViaForge

Client-side Implementation of the Via* projects for Minecraft Forge
GNU General Public License v3.0
120 stars 33 forks source link

Replaced jank GUI by ViaMCP's slider #69

Closed Nixuge closed 11 months ago

Nixuge commented 11 months ago

Title again, 95% of the work was already done, just tied up things a bit and ported to Forge

Didn't delete GuiProtocolSelector even tho it's unused as ViaMCP doesn't seem to have deleted it either?

Nixuge commented 11 months ago

Oops seems like my previous PR is in there too, it's basically useless now tho (changes GuiProtocolSelector which is unused), I can open another PR if you want to keep things a bit cleaner

FlorianMichael commented 11 months ago

No thanks, I want ViaForge to keep the GUI, the code of the slider is just way too bad, I might make a better slider sometime, because you could then also add.

Nixuge commented 11 months ago

I agree the slider's code isn't the best, but is there really a need to keep only the horrendous GUI instead ?

FlorianMichael commented 8 months ago

I will look into a "good" implementation/solution for both slider and slot gui