search

ViaVersion / ViaRewind-Legacy-Support

Provides additional features for ViaRewind for Paper servers.
https://hangar.papermc.io/ViaVersion/ViaRewindLegacySupport
GNU General Public License v3.0
23 stars 10 forks source link

Sound Listener Improvements & Fix for 1.19.3+ #61

Closed MetallicGoat closed 1 year ago

MetallicGoat commented 1 year ago

Now using Spigot API for sound listener while using 1.17 and above instead of that cryptic NMS. In doing so, we also fix issue with the SoundListener throwing errors on 1.19.3 and up

Fixes #56 Fixes #60

kennytv commented 1 year ago

This breaks on 1.12 servers

MetallicGoat commented 1 year ago

This breaks on 1.12 servers

Looks like it might have already been broken on 1.12.2 (see issue #46 )

Nevertheless, I will add a fix to this pr shortly!

Kichura commented 1 year ago

Have other server versions been tested aswell before hand? (1.9, 1.10, 1.11, you name it)

MetallicGoat commented 1 year ago

I have not changed the NMS for those versions so it should be fine. However, if you like I can test them all too. I have only changed how it is working for 1.17+ and removed all the NMS from newer versions replacing it with API.

As of now I have tested on 1.19.4 and 1.16.5

MetallicGoat commented 1 year ago

I have re-added some of the old NMS I removed by mistake, and have now tested on 1.10, 1.12, 1.16.5, and 1.19.5. I believe this is now good to go unless there is anything else that you believe I should test

kennytv commented 1 year ago

Thanks