ViaVersion / ViaRewind

ViaBackwards addon to allow 1.8.x and 1.7.x clients on newer server versions.
https://hangar.papermc.io/ViaVersion/ViaRewind
GNU General Public License v3.0
245 stars 77 forks source link

Holograms falling in void on 1.7 Client causes a Witch to appear at Hologram location #425

Closed Phirion closed 1 year ago

Phirion commented 1 year ago

/viaversion dump Output

https://dump.viaversion.com/9dd1656c41969a8b770ebb290a331d5d8767eae4d4acbbf1cd67fe381e99958e

Console Error

Put the paste.gg link or text here.

Bug Description

When 1.7 users connect to a 1.8 server they will see all Holograms fall in the void which causes a witch to appear on the Hologram location.

For 1.8 users Holograms appear normal like they suppose to appear.

Steps to Reproduce

  1. Login on 1.7.10 on 1.8 server.
  2. Have Holograms created using the HolographicDisplays plugin.
  3. See how they fall in the void regardless where you have placed them.

Expected Behavior

The Holograms should be displayed as how they do on 1.8+ without falling into void.

Additional Server Info

I don't use BungeeCord on my server.

I've tested this on a localhost with ViaVersions,Viarewind and the HolographicDisplays plugins but this still causes the issue to appear.

Checklist

Barvalg commented 1 year ago

Platform: 1.8.8--R0.2--SNAPSHOT%20%28MC%3A%201.8.8%29
ViaVersion (4.5.2-SNAPSHOT): Even with master
ViaRewind(2.0.3-SNAPSHOT): Even with master

c0dingnoobi commented 1 year ago

413 :/

c0dingnoobi commented 1 year ago

I had this issue for months. I went through all latest commits recently. e6b8b6937ebd80dcbeaa8670fc960b3d4164baf6 was the last comit where everything worked perfectly. since 49067f8f06cd0a41ac1afe463125c81541a7c69f 1.7 players get kicked whenever holograms unloads/reloads (either when reloading through command or walking out of hologram range) with this error (which seems to be related to the entity destruction) after the next commit 9e4ac93f10158c7bfa7c56f0d49a16a757e9037d ops problem occured. neither does it print a stacktrace nor does it kick the client. as op described the hologram just falls into void and a witch spawns there

c0dingnoobi commented 1 year ago

Feel free to use my fork @Phirion