ViaVersion / ViaRewind

ViaBackwards addon to allow 1.8.x and 1.7.x clients on newer server versions.
https://hangar.papermc.io/ViaVersion/ViaRewind
GNU General Public License v3.0
245 stars 77 forks source link

Commit cd8306a pushed to master instead of dev, causing ViaRewind-master to be incompatible with ViaVersion-master #450

Closed buzzcoding closed 1 year ago

buzzcoding commented 1 year ago

/viaversion dump Output

https://dump.viaversion.com/02fdc076abf03b762ded5d3d3dd681831eda534b249f626b213e91eb78a122cd

Console Error

https://paste.gg/p/anonymous/d7ebde7bdcda43e9867cc4cafe34a1f3

Bug Description

The current build of ViaVersion on the dev branch has a change that requires an update in ViaRewind to support running together with it. The needed change is made in ViaRewind commit cd8306a.

However, this change was pushed to ViaRewind-master instead of ViaRewind-dev, when it is a change needed to support ViaVersion-dev. Now, ViaRewind-master depends on ViaVersion 4.8.0-23w32a-SNAPSHOT, and since the change is not in ViaVersion-master, but in ViaVersion-dev, using the latest master builds of the Via* plugins together causes an error that makes ViaRewind disable itself.

Steps to Reproduce

  1. Create a Paper server
  2. Install the latest versions of ViaVersion, ViaBackwards, and ViaRewind from https://ci.viaversion.com
  3. Start the server and watch the console

Expected Behavior

The server should start up with no errors when using the versions which are supposed to be compatible together

Additional Server Info

No response

Checklist

Barvalg commented 1 year ago

Platform: git--Paper--167%20%28MC%3A%201.20.1%29
ViaVersion (4.7.1-SNAPSHOT): Even with master
ViaBackwards(4.7.1-SNAPSHOT): Even with master
ViaRewind(2.0.4-SNAPSHOT): Even with master

FlorianMichael commented 1 year ago

Fixed