ViaVersion / ViaRewind

ViaBackwards addon to allow 1.8.x and 1.7.x clients on newer server versions.
https://hangar.papermc.io/ViaVersion/ViaRewind
GNU General Public License v3.0
245 stars 79 forks source link

1.7.10 Anvil works incorrectly (Required level cost is different between 1.7 and 1.8.) #496

Open Lefiy opened 4 months ago

Lefiy commented 4 months ago

/viaversion dump Output

https://dump.viaversion.com/0713a343db61d8ba175f4358d6e5b3ccd1d4fc1aa73837cf433f674bed592389

Console Error

No Errors

Bug Description

Sorry if this was correct behavior. When I tried to combine enchantments in 1.7 with the same content as in 1.8 with an anvil, the required levels are different. Then combine them and close inventory, they were canceled and the level disappeared. (The level came back when I made an action that would update the level.) However, using the same level as 1.8 was worked. The same thing happens not only with swords but also with armor. Sorry for bad english.

1.8 Video (Worked) https://github.com/ViaVersion/ViaRewind/assets/80197107/664c0c36-cc33-449a-9e54-70b1b53db589

1.7 Video https://github.com/ViaVersion/ViaRewind/assets/80197107/2f4890ea-a6db-4b6d-b9c6-507571aa39f2

Try combining at 1.7 with the same level as 1.8. (Worked) https://github.com/ViaVersion/ViaRewind/assets/80197107/e71abb85-d56d-4743-9174-324f94bac653

Steps to Reproduce

  1. Login with 1.8 or 1.7 client.
  2. Prepare the sword using the enchant command and the book using the enchant table.
  3. Place the anvil and work as in the video above.

Expected Behavior

If the required level is enough, it is not canceled and the levels are consumed and combined. (I think it is unavoidable that different versions have different levels of requirements.)

Additional Server Info

I deleted all the files and downloaded PaperSpigot 1.8 again. The only plugins installed are ViaVersion and ViaRewind, ViaRewind-Legacy-Support. And I do not use proxies.

Checklist

Barvalg commented 4 months ago

Platform: git--PaperSpigot--445%20%28MC%3A%201.8.8%29
ViaVersion (4.9.4-SNAPSHOT): Even with master
ViaRewind(3.0.7-SNAPSHOT): Even with master