ViaVersion / ViaRewind

ViaBackwards addon to allow 1.8.x and 1.7.x clients on newer server versions.
https://hangar.papermc.io/ViaVersion/ViaRewind
GNU General Public License v3.0
245 stars 79 forks source link

[1.8->1.7] Negative health boost effect prompts non-functional respawn screen #511

Closed calcastor closed 3 months ago

calcastor commented 3 months ago

/viaversion dump Output

https://dump.viaversion.com/be943bbbf6ed10f6f1aae5f1712118f56d8397c43127f39e01456ec6790fde61

Console Error

N/A

Bug Description

We apply a negative amplifier health boost effect in certain gameplay situations. When applying this, we have found that 1.7.10 players are prompted with a death respawn screen in which selecting respawn does nothing.

This screen has showed in select alternate situations however I have not been able to find other reproducers.

Steps to Reproduce

  1. Log on with a 1.7.10 client on a 1.8.8 server
  2. Apply a health boost effect with a negative amplifier (need separate plugin from vanilla)
  3. Potentially observe non-functional respawn screen

Expected Behavior

The negative amplifier health boost effect should not trigger the respawn screen.

Additional Server Info

No response

Checklist

Barvalg commented 3 months ago

Platform: git--SportPaper--c03663e--P.2081566--SP.aff24bb--CB.e1ebe52%20%28MC%3A%201.8.8%29
ViaVersion (4.10.2-SNAPSHOT): Even with master
ViaBackwards(4.10.2-SNAPSHOT): Even with master
ViaRewind(3.1.1): Even with master

FlorianMichael commented 3 months ago

Is this something which started happening with the current release or can you also reproduce it on this builds: ViaVersion: https://github.com/ViaVersion/ViaVersion/releases/tag/4.9.3 ViaBackwards: https://hangar.papermc.io/ViaVersion/ViaBackwards/versions/4.9.2 ViaRewind: https://hangar.papermc.io/ViaVersion/ViaRewind/versions/3.0.6

calcastor commented 3 months ago

Is this something which started happening with the current release or can you also reproduce it on this builds: ViaVersion: https://github.com/ViaVersion/ViaVersion/releases/tag/4.9.3 ViaBackwards: https://hangar.papermc.io/ViaVersion/ViaBackwards/versions/4.9.2 ViaRewind: https://hangar.papermc.io/ViaVersion/ViaRewind/versions/3.0.6

This issue does not occur on these builds.

FlorianMichael commented 3 months ago

You should try out the latest commit / dev build, it might be fixed.

calcastor commented 3 months ago

Looks to be resolved, thank you!