ViaVersion / ViaRewind

ViaBackwards addon to allow 1.8.x and 1.7.x clients on newer server versions.
https://hangar.papermc.io/ViaVersion/ViaRewind
GNU General Public License v3.0
245 stars 79 forks source link

[1.8->1.7] All buttons render as levers #513

Closed calcastor closed 3 months ago

calcastor commented 3 months ago

/viaversion dump Output

https://dump.viaversion.com/be943bbbf6ed10f6f1aae5f1712118f56d8397c43127f39e01456ec6790fde61

Console Error

N/A

Bug Description

Instead of rendering buttons placed on top or bottom of blocks as levers, all buttons are sent to 1.7.10 users as levers from a 1.8.8 server regardless of their placement.

Steps to Reproduce

  1. Log onto a 1.8.8 server with 1.7.10
  2. Place a button on a wall
  3. Observe lever sent to 1.7.10 rather than button

Expected Behavior

Only levers placed on top or bottom of blocks should render as levers or in otherwise appropriate situations

Additional Server Info

No response

Checklist

Barvalg commented 3 months ago

Platform: git--SportPaper--c03663e--P.2081566--SP.aff24bb--CB.e1ebe52%20%28MC%3A%201.8.8%29
ViaVersion (4.10.2-SNAPSHOT): Even with master
ViaBackwards(4.10.2-SNAPSHOT): Even with master
ViaRewind(3.1.1): Even with master

FlorianMichael commented 3 months ago

Is this something which started happening with the current release or can you also reproduce it on this builds: ViaVersion: https://github.com/ViaVersion/ViaVersion/releases/tag/4.9.3 ViaBackwards: https://hangar.papermc.io/ViaVersion/ViaBackwards/versions/4.9.2 ViaRewind: https://hangar.papermc.io/ViaVersion/ViaRewind/versions/3.0.6

FlorianMichael commented 3 months ago

Fixed, you need to update ViaBackwards