ViaRewind sound translate issue

pabloalba16 commented 3 months ago

`/viaversion dump` Output

https://dump.viaversion.com/1538df69f0758d73e7d68b4b35af09271f6b112037ae7268d836af71afff9da5

Console Error

Put the mclo.gs link or text here.

No errors on console, i made a video which explains it better than me: https://streamable.com/j495ix

Bug Description

Im running a 1.12.2 server which contains the minigame called MurderMystery. Everything works well except for the part of the countdown as you can watch in the video i made, it does not translate correctly the countdown sound. In native does not happen.

Steps to Reproduce

Make a 1.12.2 server with latest Via plugins (ViaVersion, ViaBackwards, ViaRewind, ViaRewind-Legacy) Run MurderMystery and create an arena Play the arena and hear the "countdown" sound

Expected Behavior

I expected the same sound as in native version on higher. On 1.20.4 theh sound does not change

Additional Server Info

Im using a fork of paper so, let me know if you want me to test it on regular paper if needed Via plugins are on the backed server, not in the proxy

Checklist

[X] Via plugins are only running on EITHER the backend servers (e.g. Paper) OR the proxy (e.g. BungeeCord), not on both.
[X] I have included a ViaVersion dump.
[X] If applicable, I have included a paste (not a screenshot) of the error.
[X] I have tried the latest build(s) from https://ci.viaversion.com/ and the issue still persists.
[X] I have looked at https://www.spigotmc.org/resources/viarewind-legacy-support.52924/ and it does not offer a fix for my problem

Barvalg commented 3 months ago

FlorianMichael commented 3 months ago

Is this something which started happening with the current release or can you also reproduce it on this builds: ViaVersion: https://github.com/ViaVersion/ViaVersion/releases/tag/4.9.3 ViaBackwards: https://hangar.papermc.io/ViaVersion/ViaBackwards/versions/4.9.2 ViaRewind: https://hangar.papermc.io/ViaVersion/ViaRewind/versions/3.0.6

pabloalba16 commented 3 months ago

Just tested ViaVersion 4.9.2 and ViaRewind 3.0.6 and does not happen, worked as expected

FlorianMichael commented 3 months ago

I can't really reproduce this issue, do you know the exactly sound which is used here? I tried to play dispenser/gui button sounds using the /playsound command but everything works fine for me.

pabloalba16 commented 3 months ago

The plugin doesn't really tell you the sounds it uses, but seems to be the CLICK sound

FlorianMichael commented 3 months ago

Which plugin is used here exactly so I can try to reproduce it?

pabloalba16 commented 3 months ago

https://github.com/Plugily-Projects/MurderMystery

FlorianMichael commented 3 months ago

Thanks

pabloalba16 commented 3 months ago

Its the CLICK sound, confirmed. I can make a video if you desire how i tested it

FlorianMichael commented 3 months ago

Does this issue also happen when using a 1.9 client?

pabloalba16 commented 3 months ago

going to test it rn

pabloalba16 commented 3 months ago

on 1.9 client does not happen

FlorianMichael commented 3 months ago

what about 1.10?

pabloalba16 commented 3 months ago

same as 1.9

FlorianMichael commented 3 months ago

And you surely tried 1.9.0 and not something like 1.9.3/4?

pabloalba16 commented 3 months ago

oh my bad, i tested 1.9.4

pabloalba16 commented 3 months ago

just tested 1.9.0, same as 1.9.4

FlorianMichael commented 3 months ago

Should be fixed, thanks for reporting and helping, download at: https://ci.viaversion.com/view/ViaRewind/job/ViaRewind/

pabloalba16 commented 3 months ago

Yes confirm it is fixed, thank YOU for the quick response and fix!

FlorianMichael commented 3 months ago

No problem!

ViaVersion / ViaRewind