search

ViaVersion / ViaVersion

Allows the connection of newer clients to older server versions for Minecraft servers.
https://viaversion.com
GNU General Public License v3.0
1.25k stars 265 forks source link

Lighting bug - visual bug: stairs slabs beacons #1280

Closed x1p closed 5 years ago

x1p commented 5 years ago

Describe the bug, provide any errors When joining with 1.14 I've noticed several visual issues

How can we reproduce it? Steps to reproduce the behavior:

  1. Login with 1.14 client on a 1.13.2 server'
  2. place stairs/slab/beacon
  3. disconnect
  4. join again

Screenshots 1.13.2 client on the left, 1.14 client on the right. Screenshot_20190424_163403

ViaVersion Dump: https://dump.viaversion.com/66e0a01d5ec7bd38d0a0ab426eefdba0b2e9a95ac9c942d9aec433fb074925d1

Additional server info BungeeCord-Bootstrap:1.14-SNAPSHOT:4cef6d1:1405 ViaVersion v 2.0.1 build 318

FormallyMyles commented 5 years ago

As suggested by someone on out discord, smooth lighting seems to be a workaround.

ishland commented 5 years ago

The same issue on Spigot

ghost commented 5 years ago

Same here, smooth lighting doesn't help.

Patbox commented 5 years ago

image The same

ghost commented 5 years ago

So there is still no Fix?

Am Do., 13. Juni 2019 um 14:41 Uhr schrieb Patbox <notifications@github.com

:

[image: image] https://user-images.githubusercontent.com/39821509/59433173-4077cc00-8de9-11e9-91c4-7b72be5ea9c2.png The same

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ViaVersion/ViaVersion/issues/1280?email_source=notifications&email_token=AJ6S3X72V7XYG2XMTW5L5OLP2I6APA5CNFSM4HIES2XKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXTR4OY#issuecomment-501685819, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ6S3XZNOVBCNR6KUSUU6UDP2I6APANCNFSM4HIES2XA .

FormallyMyles commented 5 years ago

If anyone is able to compile and test, Kenny has PR'd a fix :)

x1p commented 5 years ago

I think I managed to get that version compiled. It looks better, but not quite as real as 1.13.x Screenshot_20190730_005558

kennytv commented 5 years ago

Can you pull and compile again? Should work now.

Also, it'd be great if you could test the following: place stairs/slabs/walls somewhere where skylight would theoretically be able to reach it, place a light source (torch, glowstone, etc.) near to it, set the time to midnight (+ relog if you just placed the light source) -> destroy the light source and see if there is block light even though the light source is destroyed

x1p commented 5 years ago

It all looks natural now. Left = version 2.1.4 build 361, Right = your latest version Screenshot_20190730_172558 Maybe others can verify on their own server as well...

Kvosty commented 5 years ago

Where i Can download 2.1.4 ?

x1p commented 5 years ago

I don't know If this is 100% correct, but the way I did it was: git clone -b non-full-light https://github.com/KennyTV/ViaVersion.git cd ViaVersion mvn clean package install

x1p commented 5 years ago

This patch works fine only farmland is still dark Screenshot_20190829_214603

Hope this patch will be released some day

kennytv commented 5 years ago

When exactly did you pull the pr last? On July 30th I added those to the fix. And thanks for the feedback 😄

x1p commented 5 years ago

My pull was from 30th July 17:00 CEST. I will try once more. Looking forward to the day this gets merged.

x1p commented 5 years ago

Redid the test. Existing farms are dark New farms are light until the player leaves the server and rejoins. Then it's dark again. Screenshot_20190829_235022

kennytv commented 5 years ago

Used a < instead of <=, so this one specific farmland state wasn't checked 🤔 - it's now fixed, thanks for testing it