ViaVersionMCP / ViaMCP

ViaVersion VersionSwitcher for Minecraft Coder Pack (MCP)
GNU General Public License v3.0
51 stars 10 forks source link

viaversion crash when downloading server resource pack #26

Closed Gh0stFace-1 closed 1 month ago

Gh0stFace-1 commented 1 month ago

Took me maybe 3 days to implement into mcp910 although thats more on me, got viaversion working and exported the jar, launced 1.8.8 client and set viaversion to 1.19 and got kicked from a server with the error "Internal exception:java.lang.illegalArgumentException: Parameter 'directory' is not a directory" this was fixed by making the directory server-resource-packs in my .minecraft folder however now when i join a server the game crashes trying to download it

FlorianMichael commented 1 month ago

That doesn't sound like a ViaVersion related issue at all, we don't modify anything regards resource pack and the crashes are probably just from the resource pack itself which doesn't get converted to a 1.8 resource pack

Gh0stFace-1 commented 1 month ago

thank you would you know if its possible for me to write it into the code so the resource packs will be converted into 1.8? if not no worries sorry for this i am still somewhat new to java

FlorianMichael commented 1 month ago

No that would require tons of work, probably a conversion as big as ViaVersion to properly support everything. Just don't accept the resource pack or use the native client version to play there.

Gh0stFace-1 commented 1 month ago

okay yeah thanks so much for the help