search

Vibrant-Colors / node-vibrant

🎨 Extract prominent colors from an image
MIT License
2.01k stars 107 forks source link

Fix titleTextColor and bodyTextColor #118

Closed janicduplessis closed 2 years ago

janicduplessis commented 3 years ago

The logic is inverted which causes it to always return undefined.

ammmr commented 3 years ago

Hi, is there any update on this PR when this is going to get merge.

crutchcorn commented 3 years ago

Huge apologies - I must've missed this in my list of emails.

Is there any possible way we could get tests on this?

kazuuuutaka commented 3 years ago

I don't know why I found this changes merged into master. https://github.com/Vibrant-Colors/node-vibrant/commit/42eac3593a3e1c897f798d388f058b0c71d06602

janicduplessis commented 3 years ago

@crutchcorn There isn't any test infra setup in that package so that's why I didn't add any.

trivedi commented 3 years ago

@kazuuuutaka the fix was applied to the master branch, but is missing from the develop monorepo branch. and if it's already applied to master... not sure if a test is necessary.

crutchcorn commented 2 years ago

Per @trivedi's comments, this commit was merged in develop. Closing, since this has been made in both places.

No release in develop yet, but that's because yester-me made a mess of the releases - it's a disaster and I'm working on fixing it soon.