Vicious-wow / XIV_Databar

AddOn for WoW that displays a databar at the bottom/top of the screen with several modules and customization options.
43 stars 16 forks source link

Attempt at Speed Module #6

Closed miketrethewey closed 4 years ago

miketrethewey commented 4 years ago

Updates on subzone transition. Tried to update on a timer but couldn't figure it out.

miketrethewey commented 4 years ago

Works on Mikeprod/XIV_Databar#57

Vicious-wow commented 4 years ago

I do not intend to merge this PR as I don't really see the point of having a speed module in a databar that is unique for its minimalistic nature. To help you for your own implementation of this module, I suggest you take a look at C_Timer.NewTicker(). A speed module, in my mind, should simply be a frame with a number that gets your speed every x frames. There should be no other event handlers or a tooltip necessary at all.

miketrethewey commented 4 years ago

I do not intend to merge this PR as I don't really see the point of having a speed module in a databar that is unique for its minimalistic nature.

Sounds good to me. I did some work on it since it was an outstanding issue on the parent project.

I suggest you take a look at C_Timer.NewTicker()

Ooh, I'll check that out!