search

ViciousFish / buzzwords

A browser based word strategy game featuring frictionless link-based multiplayer. Try it today!
https://buzzwords.gg
Apache License 2.0
48 stars 9 forks source link

Thought about making the definition item look a little neater but the definition overflow issue still needs to be solved #117

Closed NguyenDa18 closed 2 years ago

NguyenDa18 commented 2 years ago
Screen Shot 2022-08-21 at 11 27 58 PM
chuckdries commented 2 years ago

First off, thanks for the contribution🎉!

I like where you're headed with this, but it's a little too light in light theme.

image

For text colors, I have defined tailwind colors text and textInverse that automatically become black or white depending on the theme the user has selected. These can be used for text with text-* classes, but also for anywhere else tailwind colors can be used (borders, divide, etc). Generally what I do for text is I assign the text-text or text-textInverse class, then to change the "lightness" I assign an opacity-* class to the element. Do you have the Tailwind CSS IntelliSense extension for vscode? It'll provide autocomplete in all className fields.

Also, this is just a personal style thing, but maybe look at doing list bullets for meaning.definitions instead of the divider. I suspect it might look cleaner, but it also might look more cluttered so I'm not married to that idea.