Repeating annual event??

VickiLanger / LGBTQ-of-the-day-bot

Twitter bot tweeting fun goofy lgbtq things and queer history of the day

https://twitter.com/LGBTQotd

GNU General Public License v3.0

80 stars 173 forks source link

Closed VickiLanger closed 3 years ago

VickiLanger commented 3 years ago

Describe the bug This same event keeps getting posted, even on days when it shouldn't

Expected behavior Events should only post on their assigned dates

Screenshots Screenshot of Twitter showing multiple tweets on different days posting about "trans parent day"

Don't forget to follow the bot on Twitter to see the hard work you put in.

JasirZaeem commented 3 years ago

When looking up events that have a relative date, i.e. 11-1U (1st Sunday of November ) the month is currently not taken into account. Here: https://github.com/VickiLanger/LGBTQ-of-the-day-bot/blob/cc8af39aa91fbb1358d417c19f384efb8d5818c9/tweet_annual_days.py#L37 So this event (and every relative event) can be chosen in any month, and this event gets tweeted the first Sunday of every month. I'll make a pr in a bit fixing this and a few other bugs I noticed in tweet_annual_days.py

VickiLanger commented 3 years ago

Oh! That makes so much sense!