Final Feedback - Githubissues

Cleanliness

Start ID names with the contextual grouping ‘bg-mountain’
Remove extra divs https://github.com/Victor-Talons/GDMA-2662-Assignment-3/blob/5c3ed4d45c106e153470f5eaf73290543abc3d54/index.html#L32
Abbreviate utility class names “vertical-space-small”
Overusing classes, the standard paragraphs on the page should not need classes https://github.com/Victor-Talons/GDMA-2662-Assignment-3/blob/5c3ed4d45c106e153470f5eaf73290543abc3d54/index.html#L64
Footer should not need a class, target contextually
If a class is not used more than once per page it should be an ID
Font weight and font style should be included in font shorthand
Complex contextual selectors should be under components https://github.com/Victor-Talons/GDMA-2662-Assignment-3/blob/5c3ed4d45c106e153470f5eaf73290543abc3d54/css/main.css#L116
Simplify selectors
Group repeating styles
Hero styles should only contain hero related styles, they do not need to be broken up by ID

Completion

Functionality

Missing hover state on text links in footer
Offset values for smooth scroll on large need to be adjusted Image C+
Name images so the contextual grouping is first ‘hero-‘.
Images that are named with ‘hero-‘ are used in more locations than just hero
Use a contextual name based on the image, not the page it’s used on. What page it’s used on could change.
Only images that go in through the HTML need an @2x counterpart

Responsiveness Small

hero content is too large, incorrect weight
intro paragraph is too large
inconsistent vertical spacing
blockquote treatment should match body copy
missing tree bullets
smooth scroll offset needs adjusted
incorrect nav styles Medium
Would like to see consideration for medium layout. Examples: about / take action on home page could be 2-up, achievements list can be 2-up
Inconsistent vertical space
logo and nav lock up on home is different than other pages
about nav is a bit too large
intro-p is too large, needs more line height

Semantics

Title for each page should be unique
Missing data-rjs attribute in the HTML to call up the retina image
This is the font size that should be set as the base HTML element . It will then be applied to both the paragraphs and lists so that base typography is consistent https://github.com/Victor-Talons/GDMA-2662-Assignment-3/blob/5c3ed4d45c106e153470f5eaf73290543abc3d54/css/main.css#L98
border-radius is a CSS3 property and should have vendor prefixes

Victor-Talons / GDMA-2662-Assignment-3