search

VictorAlbertos / RxSocialConnect-Android

OAuth RxJava extension for Android.
Apache License 2.0
257 stars 22 forks source link

Activity Connect bug #21

Closed Cool04ek closed 7 years ago

Cool04ek commented 7 years ago

Hi, thank you for this awesome library. I found it very useful. However, I have encountered an unpleasant bug I would like to report. When you start ActivityConnect and then close it before webview has loaded you will get NPE in this line if (!url.startsWith(service.callbackUrl())) return super.shouldOverrideUrlLoading(view, url); because activity is already closed and service is null. I can provide PR with fix as well.

Cool04ek commented 7 years ago

Here is PR with fix I assume can help - #22

VictorAlbertos commented 7 years ago

Closed by #22

Cool04ek commented 7 years ago

By the way, would you provide new version for the maven repo so I can you lib as gradle dependency?