search

VictorAlbertos / RxSocialConnect-Android

OAuth RxJava extension for Android.
Apache License 2.0
257 stars 22 forks source link

service null check #24

Closed Cool04ek closed 7 years ago

VictorAlbertos commented 7 years ago

This is not the same implementation performed against the branch 1.x.

Why did you add @TargetApi? The last time I checked it was suggested to use the deprecated one. In any case, it is not the same implementation as the branch 1.x. Please, refactor your changes to be the same as the 1.x brand and commit them again.

And, next time, please don't format the code. Try to be as minimal as possible with your changes.

Thanks.

Cool04ek commented 7 years ago

Of course. I've rolled back those changes and provided update. Please check

VictorAlbertos commented 7 years ago

Thanks @Cool04ek. I'm gonna to release a new version right now.

VictorAlbertos commented 7 years ago

Done!