VictorAvelar / mollie-api-go

Golang wrapper for Mollie's REST API with full resource coverage.
https://www.mollie.com/en/developers/packages
MIT License
59 stars 35 forks source link

Payment Api Method is either an Array or String #316

Closed borissmidt closed 5 months ago

borissmidt commented 7 months ago

Is your feature request related to a problem? Please describe. According to the API it should be possible to set multiple payment methods instead of one. https://docs.mollie.com/reference/v2/payments-api/create-payment

The reason i would like this is because in belguim kbc, bellfius and bancontact are the most commen. But kbc and belfius are better priced. But other payment methods are not relevant to my usecase.

Describe the solution you'd like A way to set multiple methods as an array or a workaround to set the method field.

VictorAvelar commented 7 months ago

Hi @borissmidt. I'm going to have a look and try to come up with an implementation solution for this use case.

VictorAvelar commented 6 months ago

After further investigation this is not hard to fix, however it would be a breaking change. I can add it to the library and then you would need to either wait for the 4.0 tag or just use @ master as version when pulling your go module. I know this is risky and not ideal but it is the best compromise I can offer. I am expecting to start working in full to release v4 latest by the end of February and ideally earlier.

borissmidt commented 6 months ago

Thank you for the fast response,

I can wait and use bancontact only for now and i'm glad it gets fixed in the next version.

On Fri, 2 Feb 2024, 13:33 Victor Hugo Avelar Ossorio, < @.***> wrote:

After further investigation this is not hard to fix, however it would be a breaking change. I can add it to the library and then you would need to either wait for the 4.0 tag or just use @ master as version when pulling your go module. I know this is risky and not ideal but it is the best compromise I can offer. I am expecting to start working in full to release v4 latest by the end of February and ideally earlier.

— Reply to this email directly, view it on GitHub https://github.com/VictorAvelar/mollie-api-go/issues/316#issuecomment-1923716169, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNXZFQMF6QLFI4AWWJTY7LYRTMJPAVCNFSM6AAAAABCOMXPNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRTG4YTMMJWHE . You are receiving this because you were mentioned.Message ID: @.***>

VictorAvelar commented 5 months ago

Resolved in #326

To create a new payment: https://github.com/VictorAvelar/mollie-api-go/pull/326/files#diff-c3a9cffe9a462f66c4ad1852562d742893650d95ec6a2612df417b981188a88bR73

To update a payment: https://github.com/VictorAvelar/mollie-api-go/pull/326/files#diff-c3a9cffe9a462f66c4ad1852562d742893650d95ec6a2612df417b981188a88bR150