VictorCazanave / react-svg-map

A set of React.js components to display an interactive SVG map
https://victorcazanave.github.io/react-svg-map/
MIT License
229 stars 48 forks source link

Addition of Utah Map #14

Closed hopkira closed 6 years ago

hopkira commented 6 years ago

Victor, you’ve built a great tool - as a mark of gratitude and respect, here’s a map of the Counties of Utah!

codecov-io commented 6 years ago

Codecov Report

Merging #14 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #14   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           7      7           
  Branches        1      1           
=====================================
  Hits            7      7

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ff6e30e...9bc5ac9. Read the comment docs.

VictorCazanave commented 6 years ago

Thanks @hopkira 😃 I'll review it this weekend

Edit: I've been very busy, so I'll try to review it next week, sorry 🙏

VictorCazanave commented 6 years ago

@hopkira your first commit is perfect! But could you remove the second one? The examples are only used for the demo page and testing the new maps, so you don't need to add a new one. I think the other modifications of the second commit are for your personal usage.

hopkira commented 6 years ago

@VictorCazanave - you're quite right, I didn't intend for those changes to come your way - I have reverted the commit (I hope). Thanks Richard