VictorCazanave / react-svg-map

A set of React.js components to display an interactive SVG map

https://victorcazanave.github.io/react-svg-map/

MIT License

225 stars 47 forks source link

World Map Added #22

Closed hugomosh closed 4 years ago

hugomosh commented 5 years ago

Added world map

Extracted from low-resolution map: https://www.amcharts.com/svg-maps/?map=world

Tested

hugomosh commented 5 years ago

This time it fails beacuse


 FAIL  __tests__/radio-svg-map.test.js
  ● Test suite failed to run
    TypeError: Cannot assign to read only property 'Symbol(Symbol.toStringTag)' of object '#<process>'

      at exports.default (node_modules/jest-util/build/create_process_object.js:14:34)
 FAIL  __tests__/checkbox-svg-map.test.js
  ● Test suite failed to run
    TypeError: Cannot assign to read only property 'Symbol(Symbol.toStringTag)' of object '#<process>'

      at exports.default (node_modules/jest-util/build/create_process_object.js:14:34)
 FAIL  __tests__/svg-map.test.js
  ● Test suite failed to run
    TypeError: Cannot assign to read only property 'Symbol(Symbol.toStringTag)' of object '#<process>'

      at exports.default (node_modules/jest-util/build/create_process_object.js:14:34)

VictorCazanave commented 5 years ago

Thanks @hugomosh 😃 I'll review it and fix the Jest bug this weekend

codecov-io commented 5 years ago

Codecov Report

Merging #22 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #22   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          76     76           
  Branches       17     17           
=====================================
  Hits           76     76

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b40caff...a52b83a. Read the comment docs.

VictorCazanave commented 5 years ago

The new version of Node fixed the issue.

However as written in the contributing section, could you add:

a simple snapshot test (like the one of Utah)
the map with the list of locations (countries) in the maps section of README

In my test, the right part of Russia looks cropped. Do you have the same issue?

hugomosh commented 5 years ago

The new version of Node fixed the issue.

However as written in the contributing section, could you add:

a simple snapshot test (like the one of Utah)

the map with the list of locations (countries) in the maps section of README

In my test, the right part of Russia looks cropped. Do you have the same issue?

Oh I see Russia cropped, my bad. It is the view port, I need to adjust it right to also not have whitespace. Sure, I will write the information.

Thank you for the time spent.

VictorCazanave commented 5 years ago

@hugomosh since v2.0.0 the maps have been moved to another package. So if you still want to add the world map, could you re-create this PR on v1 branch or create a new one on svg-maps please?