VictorCazanave / react-svg-map

A set of React.js components to display an interactive SVG map
https://victorcazanave.github.io/react-svg-map/
MIT License
229 stars 48 forks source link

react 17 update #54

Closed RamonDonnell closed 2 years ago

RamonDonnell commented 3 years ago

Dependency and jest setup update for react 17. Uses unofficial @wojtekmaj/enzyme-adapter-react-17

https://github.com/VictorCazanave/react-svg-map/issues/53

VictorCazanave commented 3 years ago

Thanks for your contribution @RamonDonnell ! 😃

Does it solve the issue https://github.com/VictorCazanave/react-svg-map/issues/53? If yes, since the components aren't modified, can't we just update the peerDependencies to support both React 16 and 17 (^16.0.0 || ^17.0.0)? 🤔

sdnalloh commented 2 years ago

Please resolve and merge this pull request. I'd like to use react-svg-map with react-17, and I'm sure many other people would too.

piotrgregor commented 2 years ago

Yes, other people too ;p Can this be merged please.

VictorCazanave commented 2 years ago

As mentioned in https://github.com/VictorCazanave/react-svg-map/issues/53, I didn't see any issue using these components with React 17. So @sdnalloh @piotrgregor what do you need exactly? Only updating the peer dependencies to also support React 17? If there is an issue with React 17, please provide a repository with a minimal example to reproduce it.

VictorCazanave commented 2 years ago

Thanks again for your contribution @RamonDonnell, but stopping React 16 support is a major change that will be done in the v3