search

VictorNine / bitwarden-go

A Bitwarden-compatible server written in Golang
MIT License
250 stars 33 forks source link

Unable to delete items and folders with bitwarden-web v1.24.0 #27

Open leonghui opened 6 years ago

leonghui commented 6 years ago

Deleting an existing item appears to work but upon refresh, the item still exists. Same behaviour when deleting folders.

Server stdout reports: 2018/03/24 04:32:25 user@user.com is trying to edit his data 2018/03/24 04:32:25 strconv.ParseInt: parsing "67/delete": invalid syntax ... 2018/03/24 04:37:57 user@user.com is trying to update a folder 2018/03/24 04:37:57 Folder 423b3f90-46ee-448d-adb0-a9f47edcef89/delete updated

EDIT: Other clients (tested: Android app 1.51.1, Firefox extension 1.25.4): Item deletion works fine. Folder deletion is broken, deleted folders reappear after sync.

Server stdout for other clients: 2018/03/24 04:48:23 user@user.com is trying to edit his data 2018/03/24 04:48:23 Cipher 68 deleted ... 2018/03/24 04:50:05 user@user.com is trying to update a folder

Odysseus16 commented 6 years ago

I have also implemented the new API. So if you want, you can try my version (but at the moment the database is not compatible with VictorNines. I plan to submit a pull request in the next time, but as I have done major changes it is hard to make my branch compatible with VictorNines.

leonghui commented 6 years ago

@Odysseus16 Thanks for your work, I am looking forward to Totp support but I will need to migrate my data over to your build for testing.

@VictorNine Issue above still exists after https://github.com/VictorNine/bitwarden-go/commit/17c1ff32c9b7f79af870ce8295cb6f5ee9b4bb16 (tested: Android app 1.51.2, Firefox extension 1.25.7, and bitwarden-web 1.25.1)

timreuscher commented 6 years ago

@Odysseus16 Does your fork support Match Detection yet? I know this one doesn’t.

VictorNine commented 6 years ago

Have you tried after the latest commit? Should be working

Sent from ProtonMail mobile

-------- Original Message -------- On Apr 12, 2018, 19:04, timreuscher wrote:

@Odysseus16 Does your fork support Match Detection yet? I know this one doesn’t.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

timreuscher commented 6 years ago

@VictorNine My bad. It does work after the update. I made the change in the web vault but hadn’t synced it to my browser add-on. Appreciate the work on this.

VictorNine commented 6 years ago

Good to hear. I'll look in to the folders as well

davehope commented 5 years ago

@victornine, did you ever get to look at the folder deletion issue?