search

VictorPhilipp / Cities-Skylines-Traffic-Manager-President-Edition

Cities: Skylines Traffic Manager: Traffic President Edition
http://steamcommunity.com/sharedfiles/filedetails/?id=583429740
MIT License
147 stars 51 forks source link

All TMPE data silently corrupted/removed on any level load error #89

Closed penma closed 5 years ago

penma commented 6 years ago

When for any reason a saved game contains data but it cannot be loaded, it is silently ignored and destroyed after saving. This should obviously not happen and the user should be given some kind of notice. (The average user will probably not know what to do anyway when presented with any kind of error dialog, but just silently killing all data and letting user notice only days later is not a good thing either - this way they might at least not destroy their only copy of a savegame)

Seems code is already there, just the dialog box display commented out: https://github.com/VictorPhilipp/Cities-Skylines-Traffic-Manager-President-Edition/blob/f3df93450ec2359048a19c7a52c4e79c8abc31ef/TLM/TLM/State/SerializableDataExtension.cs#L105

(noticed because for some reason a local build of current git master is unable to load data saved by current steam workshop version, don't know why, that's a different issue though)

VictorPhilipp commented 6 years ago

I disabled the message because it does not provide any value to the user. At the time it shows (during loading) damage has already been done (during saving). If it shows during saving then I would also have to provide countermeasures (e.g. skip saving). That in turn could lead to new problems where TMPE's internal state may become misaligned with the game state.

VictorPhilipp commented 5 years ago

moved