Victoria129 / Record-Manager

MIT License
0 stars 0 forks source link

https://github.com/Victoria129/ruby-capstone/projects/1 #38

Open Victoria129 opened 1 year ago

Victoria129 commented 1 year ago

Project link: https://github.com/Victoria129/ruby-capstone/projects/1

We are two people in this group. Team member #1 - Samuel Amankwaa-Frempong Team member #2 - Victoria Tumwebaze

Ismailco commented 1 year ago

Hi @Victoria129, @frempongdev,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project, that has missing information in the Description, kindly make sure to add a link to the GitHub Project

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

Abenezer-Tilahun commented 1 year ago

Hi @frempongdev @Victoria129 ,

Great job for implemented the some of the Project Requirement , but there are some changes that need to be implemented in order to proceed to the next project 👍

Highlights 👏🏻

✔️ Good Job for Provide link to their GitHub project ✔️ Good Job for Provide Information about the number of people in their group ✔️ Good Job for Implemented Ruby group capstone: set up your Kanban board

almost

Required Changes ♻️

Check the comments below the review.

Capture

Capture

Capture

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

jerryowusu commented 1 year ago

Hi @Victoria129 & @frempongdev

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

weldone

Highlights

:heavy_check_mark: Number of points for each card added :heavy_check_mark: Great effort in making the requested changes

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.