Open hagen1778 opened 10 months ago
cc @zekker6
@hagen1778 It seems to me like a better approach would be to add an optional GET param to vmselect instead. This param would enforce adding tenant labels to the series. This way it won't be required to store tenant info twice(both as prefix and in labels), but this will increase load on vmselect as it will be required to append artificial labels. Wdyt?
Is your feature request related to a problem? Please describe
A clustered version of VictoriaMetrics supports multitenancy via labels. It expects that user will send a payload of the following form:
However, removing vm_account_id/vm_project_id may not suite all cases. For example, if user would like to get global view across all tenants via promxy or other proxy it would be convenient to retain mentioned labels, so responses from multiple tenants were distinguishable. See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1434#issuecomment-1895321710
Retaining tenant labels would also simplify multitenancy in vmalert.
Describe the solution you'd like
It would be nice to make
insert/multitenant
API to accept optional GET paramkeep_tenant_labels=<bool>
. When set totrue
, this param will instruct vminsert to retain vm_account_id/vm_project_id on ingestion.