search

VictoriaMetrics / helm-charts

Helm charts for VictoriaMetrics, VictoriaLogs and ecosystem
https://victoriametrics.github.io/helm-charts/
Apache License 2.0
329 stars 324 forks source link

victoria-metrics-single helm chart 0.10.1 statefulset breaks when providing image pull secrets #1285

Closed nick-oconnor closed 3 weeks ago

nick-oconnor commented 3 weeks ago

I get the following error attempting to deploy:

Error: YAML parse error on victoria-metrics-single/templates/server-statefulset.yaml: error converting YAML to JSON: yaml: line 31: did not find expected ',' or ']'

The chart applies cleanly when I omit:

global:
  imagePullSecrets:
    - name: my-secret

I suspect that the following line is expecting a string instead of an array: https://github.com/VictoriaMetrics/helm-charts/blob/c6b08e553712124165d5cb20a6776b28752dc058/charts/victoria-metrics-single/templates/server-statefulset.yaml#L40

AndrewChubatiuk commented 3 weeks ago

hey @nick-oconnor thanks for submitting an issue, created PR with a fix

nick-oconnor commented 3 weeks ago

That was super fast! :pray: :rocket:

AndrewChubatiuk commented 2 weeks ago

hey @nick-oconnor. thanks for patience. global image pull secrets are fixed in 0.11.0