VictoriaMetrics / helm-charts

Helm charts for VictoriaMetrics, VictoriaLogs and ecosystem
https://victoriametrics.github.io/helm-charts/
Apache License 2.0
348 stars 332 forks source link

feature: support HPA for STS #1641

Closed vhajdukd closed 4 weeks ago

vhajdukd commented 4 weeks ago

Chart name and version, where you feel a lack of requested feature chart: victoria-metrics-agent version: v0.12.1

Is your feature request related to a problem? Please describe. Allow statefulset to be configured as the target for hpa. One may want to retain tmp queue for gracefulshutdowns during for example image tag changes / upgrades to pods.

Describe the solution you'd like Allow statefulset to be configured as the target for hpa.

Describe alternatives you've considered Deployment won't fulfil that role as emptyDir will be cleaned (tmp queue) on pods rollout.

Additional context This is to facilitate this part of the documentation:

AndrewChubatiuk commented 4 weeks ago

hey @vhajdukd how are you going to use HPA with VMAgent?

vhajdukd commented 4 weeks ago

Thanks for the fast fix. How we use it ? - This is in case there will be a surge in traffic (ppl are sending to our vmagents) and queue will build up before rollout of new version.

This is to not lose single scrape metrics (its not running in clusterMode).

AndrewChubatiuk commented 4 weeks ago

starting the next release HPA will target StatefulSet if you have horizontalPodAutoscaler.enabled: true and statefulset.enabled: true

vhajdukd commented 4 weeks ago

When can I expect the release of "0.14.4" ?

AndrewChubatiuk commented 4 weeks ago

It's already available