search

VictoriaMetrics / helm-charts

Helm charts for VictoriaMetrics, VictoriaLogs and ecosystem
https://victoriametrics.github.io/helm-charts/
Apache License 2.0
301 stars 307 forks source link

Duplicated VictoriaMetrics datasource #964

Open todeb opened 2 months ago

todeb commented 2 months ago

when enabled VictoriaMetrics datasource plugin for grafana

grafana:
  plugins:
    - "https://github.com/VictoriaMetrics/grafana-datasource/releases/download/v0.5.0/victoriametrics-datasource-v0.5.0.zip;victoriametrics-datasource"
   grafana.ini:
    plugins:
      # Why VictoriaMetrics datasource is unsigned: https://github.com/VictoriaMetrics/grafana-datasource/blob/main/README.md#why-victoriametrics-datasource-is-unsigned
      allow_loading_unsigned_plugins: victoriametrics-datasource

  # Change datasource type in dashboards from Prometheus to VictoriaMetrics.
  # you can use `victoriametrics-datasource` instead of `prometheus` if enabled VictoriaMetrics Datasource above
  defaultDatasourceType: "victoriametrics-datasource"

instead of VictoriaMetrics prometheus datastource that was shown before, there are 2 victoriametrics datasources with slightly different name with very same configuration.

It is a bit confusing and redundant.

Haleygo commented 2 months ago

Hello! No, the default one can't be disabled now when you enabled vmsingle or vmcluster. And change .Values.grafana.defaultDatasourceType to "victoriametrics-datasource" will make two datasources the same. I believe the original idea is having two datasources with different types as prometheus and victoriametrics. And they can be duplicated when .Values.grafana.defaultDatasourceType changed to "victoriametrics" as well.