VictoriaMetrics / operator

Kubernetes operator for Victoria Metrics
Apache License 2.0
410 stars 141 forks source link

VMAgent livenessProbe not using TLS #896

Closed lassizci closed 3 months ago

lassizci commented 4 months ago

I have VMAuth with tls enabled and with:

apiVersion: operator.victoriametrics.com/v1beta1
kind: VMAuth
metadata:
  name: vmauth
  namespace: monitoring
spec:
  image:
    tag: v1.99.0
  secrets:
    - vmauth-cert
  extraArgs:
    tls: "true"
    tlsCertFile: /etc/vm/secrets/vmauth-cert/tls.crt
    tlsKeyFile: /etc/vm/secrets/int-vmauth-cert/tls.key

the container spec has:

    livenessProbe:
      failureThreshold: 10
      httpGet:
        path: /health
        port: 8427
        scheme: HTTP
      periodSeconds: 5
      successThreshold: 1
      timeoutSeconds: 5
    readinessProbe:
      failureThreshold: 10
      httpGet:
        path: /health
        port: 8427
        scheme: HTTPS
      periodSeconds: 5
      successThreshold: 1
      timeoutSeconds: 5

So the livenessProbe doesn't have proper scheme while readinessProbe does. As a result the container keeps crashing.

The operator image is docker.io/victoriametrics/operator:v0.42.2

f41gh7 commented 3 months ago

Must be fixed at v0.42.0 release